Remove public domain checkbox from signup and terms pages #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
force-pushed
the
pd-declaration
branch
from
a2a6353 to
41a1867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4455 (comment), #4455 (comment), #4455 (comment) for reasons to remove the checkbox from the signup page.
The checkbox is confusingly placed right above the Sign Up button:
Users might think they have to check it in order to proceed, but they actually don't have to do it. If they check it accidentally and register an account, there's no way to undo it.
I also removed a similar checkbox from the terms page. That page is currently not accessible for new accounts because terms are accepted by signing up. But that's probably going to change because the terms page could be reused for accepting updated terms. Supposedly terms of use were updated and many users need to accept the new terms if GDPR changes happen. If there's a public domain checkbox on that page, users also might also accidentally check it.
If anyone actually want to declare their contributions in public domain, I added a special page for that. There's a link to it from Contributor Terms on the My Settings page. I didn't make the link very noticeable because I don't expect many people to visit that page:
The page is at
/account/pd_declarationand is just a checkbox and a confirm button: