fix(mrc): fix <ActionMenu /> #14921
Open
fix(mrc): fix <ActionMenu /> #14921
+70
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjamet-ovh
requested review from
chipp972,
ghyenne,
sidlynx,
frenautvh,
qpavy and
aottr
3 tasks
rjamet-ovh
force-pushed
the
fix/gh-14914
branch
from
ab7efe8 to
62c9f2a
Compare
chipp972
previously approved these changes
Jan 15, 2025
tibs245
previously approved these changes
Jan 15, 2025
anooparveti
reviewed
Jan 16, 2025
packages/manager-react-components/src/components/navigation/menus/action/action.scss
Outdated
Show resolved
Hide resolved
rjamet-ovh
force-pushed
the
fix/gh-14914
branch
from
62c9f2a to
44a9fe5
Compare
tristanwagner
previously approved these changes
Jan 17, 2025
anooparveti
approved these changes
Jan 17, 2025
anooparveti
requested changes
Jan 17, 2025
There was a problem hiding this comment.
so the Menu component does have actions only, so Buttons are the only items accepted there (no links). If in your use case you have to navigate, please use the trigger function on the Button to do so
Following the suggestion of Francois, please implement this way.
rjamet-ovh
force-pushed
the
fix/gh-14914
branch
from
44a9fe5 to
36afa13
Compare
tibs245
reviewed
Jan 17, 2025
| @@ -21,6 +23,9 @@ export interface ActionMenuItem { | |||
| iamActions?: string[]; | |||
| urn?: string; | |||
| className?: string; | |||
| isDisabled?: boolean; | |||
| isLoading?: boolean; | |||
| color?: ODS_BUTTON_COLOR; | |||
| } | |||
There was a problem hiding this comment.
Suggested change
| } | |
| export interface ActionMenuItem { | |
| id: number; | |
| rel?: string; | |
| href?: string; | |
| download?: string; | |
| target?: string; | |
| onClick?: () => void; | |
| label: string; | |
| className?: string; | |
| } & React.ComponentProps<typeof OdsButton> |
tibs245
approved these changes
Jan 17, 2025
anooparveti
approved these changes
Jan 17, 2025
8 tasks
tristanwagner
approved these changes
Jan 20, 2025
- add download file use-case - fix menu item style - fix trigger btn clickable zone ref: 14914 Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
rjamet-ovh
force-pushed
the
fix/gh-14914
branch
from
36afa13 to
fac4c58
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developOnly FR translations have been updatedBreaking change is mentioned in relevant commitsDescription