CLN: Refactor np_can_hold_element to reduce cyclomatic complexity #60735
+262
−138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the
np_can_hold_element
function to reduce its cyclomatic complexity and improve maintainability. The function was decomposed into smaller helper functions (_handle_integer_dtype
,_handle_float_dtype
, etc.), each handling a specific dtype logic. This improves readability and reduces the complexity of the main function.Changes
np_can_hold_element
into smaller helper functions:_handle_integer_dtype
_handle_float_dtype
_handle_complex_dtype
_handle_boolean_dtype
_handle_string_dtype
flake8
and fixed style issues to comply with the project's code standards.Testing
np_can_hold_element
.Notes for Reviewers