Typescript declaration files script #7465
Open
+558
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diyaayay
changed the title
diyaayay
force-pushed
the
typescript-declarations
branch
from
0f35005 to
16149c1
Compare
diyaayay
force-pushed
the
typescript-declarations
branch
from
2face78 to
35cb018
Compare
|
I think this still needs work, the format of the output files, and cases to be handled. But, @davepagurek Do you think this would be the correct approach to bypass |
|
I think that's probably the best way forward, since it seemed pretty hard to get tsc to understand how we're adding to p5 classes dynamically. Looking good so far! |
davepagurek
reviewed
Jan 18, 2025
| function generateTypeFromTag(param) { | ||
| if (!param || !param.type) return 'any'; | ||
|
|
||
| switch (param.type.type) { |
There was a problem hiding this comment.
A more complex case you might want to try with is paletteLerp, which has an array of tuples:
p5.js/src/color/creating_reading.js
Lines 1090 to 1091 in c643b7b
Ideally that out output basically back out to its original format, or possibly Array<[p5.Color, number]>
diyaayay
force-pushed
the
typescript-declarations
branch
2 times, most recently
from
19c5fba to
35cb018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off of #6777 and #6972. WIP.
Maybe an AST based approach could be added to the current script. This still needs to handle a few cases, such as static methods.
Changes:
Screenshots of the change:
PR Checklist
npm run lintpasses