Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional title feature to ChartModule #955

Closed
wants to merge 2 commits into from

Conversation

anjalinair012
Copy link

A suggested solution to issue projectmesa/mesa-viz-tornado#23

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #955 (a2a15b5) into master (8a8e05c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     projectmesa/mesa#955   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files          19       19           
  Lines        1132     1132           
  Branches      189      189           
=======================================
  Hits         1006     1006           
  Misses         92       92           
  Partials       34       34           
Impacted Files Coverage Δ
mesa/visualization/modules/ChartVisualization.py 91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a8e05c...0de157b. Read the comment docs.

@jackiekazil
Copy link
Member

This looks good. Can you add an example implementation into one of the examples?

@jackiekazil jackiekazil self-assigned this Dec 30, 2020
@anjalinair012
Copy link
Author

Example \mesa\examples\charts\charts\server.py has been modified for testing. Please refer to mesa\docs\issue_954.rst .

Base automatically changed from master to main March 14, 2021 05:26
@JaslinRikkaz123
Copy link

I have tried this but it doesn't show the title in the chart module output. What i have to do to get the chart title?

@catherinedevlin
Copy link
Contributor

I tried producing an updated PR with this code - #1666 - but like @JaslinRikkaz123, did not see the title actually showing up on the screen. I also think that, if it is made to work, it should work with all the visualizations (bar, pie, ...), not just line.

@Corvince
Copy link
Contributor

Thank you for the PR and sorry for never putting it forward

If this is still actively followed please re-open the PR at https://github.com/projectmesa/mesa-viz-tornado
But note that we are moving towards a new pure python frontend

@Corvince Corvince closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants