Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging.Handler.lock can't be None #13409

Closed
wants to merge 1 commit into from
Closed

Fix logging.Handler.lock can't be None #13409

wants to merge 1 commit into from

Conversation

kbaikov
Copy link
Contributor

@kbaikov kbaikov commented Jan 19, 2025

Fixes: #13381

@AlexWaygood
Copy link
Member

@JelleZijlstra's comment in #13381 (comment) suggested that we shouldn't make this change, and that there was nothing to be done here

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@kbaikov
Copy link
Contributor Author

kbaikov commented Jan 19, 2025 •
edited
Loading

@AlexWaygood I think he just misunderstood the issue, because the issue title has a question mark.
It took me 2 reads to notice it :)

Or perhaps you are right.

@kbaikov
Copy link
Contributor Author

kbaikov commented Jan 19, 2025

Then should the issue #13381 be just closed?

@kbaikov kbaikov closed this Jan 19, 2025
@kbaikov kbaikov deleted the fix-logging-handler-lock branch January 19, 2025 14:51
@JelleZijlstra
Copy link
Member

My comment would imply that the issue should be closed, yes. But I'm happy to defer to others' opinions if someone disagrees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should logging.Handler.lock allow None?
3 participants
@kbaikov @AlexWaygood @JelleZijlstra