Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kt60-MU PCB #24797

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add kt60-MU PCB #24797

wants to merge 8 commits into from

Conversation

key10iq
Copy link
Contributor

@key10iq key10iq commented Jan 7, 2025

Description

kt60-MU is a 60% PCB supporting QMK and VIA, compatible with many 60% keyboards

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Added new keyboard - keyten/kt60_mu

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@key10iq
Copy link
Contributor Author

key10iq commented Jan 7, 2025

To anticipate the question, this PCB really needs a backlight definition, despite the fact that it only has two LEDs (one of which is defined as a Caps Lock indicator), lol

keyboards/keyten/kt60_mu/keyboard.json Outdated Show resolved Hide resolved
keyboards/keyten/kt60_mu/keyboard.json Outdated Show resolved Hide resolved
keyboards/keyten/kt60_mu/keyboard.json Show resolved Hide resolved
key10iq and others added 4 commits January 8, 2025 00:28
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
keyboards/keyten/kt60_mu/keyboard.json Outdated Show resolved Hide resolved
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@key10iq key10iq requested review from dunk2k and sigprof January 7, 2025 21:46
@key10iq
Copy link
Contributor Author

key10iq commented Jan 19, 2025

@dunk2k sorry for ping, but...

@dunk2k
Copy link
Contributor

dunk2k commented Jan 19, 2025

@dunk2k sorry for ping, but...

Hi @key10iq,
I'm not a QMK Collaborator so unfortunately my approval wouldn't count toward this PR being merged. I'm able to give this PR another look over and subsequent approval if it would be meaningful to you?

Copy link
Contributor

@sigprof sigprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits (trailing spaces and a trailing comma which would make the file not a valid JSON).

keyboards/keyten/kt60_mu/keyboard.json Outdated Show resolved Hide resolved
@key10iq
Copy link
Contributor Author

key10iq commented Jan 20, 2025

@dunk2k sorry for ping, but...

Hi @key10iq, I'm not a QMK Collaborator so unfortunately my approval wouldn't count toward this PR being merged. I'm able to give this PR another look over and subsequent approval if it would be meaningful to you?

Oh, sorry, for some reason I always thought you were a QMK Collaborator, haha. In general, I'll be glad if you look over my PR again!

Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants