Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add RGB Matrix configuration to lotus58 #24820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryanalves
Copy link

@bryanalves bryanalves commented Jan 17, 2025

Description

Provide an RGB matrix for lotus58 keyboards.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This should be added to the top keyboard level info.json file, so it is used by all revisions (since the only difference is microcontroller)
  • Please run qmk format-json on the file you modify (spaces instead of tabs, mostly)

@bryanalves
Copy link
Author

bryanalves commented Jan 18, 2025

  • This should be added to the top keyboard level info.json file, so it is used by all revisions (since the only difference is microcontroller)
  • Please run qmk format-json on the file you modify (spaces instead of tabs, mostly)

Made the requested updates. I had originally had tabs for the change because that is what matched the rest of the formatting for the file. The top level info.json is properly formatted with spaces instead of tabs, and so I ensured that I matched the format of that file as well.

@drashna drashna self-requested a review January 18, 2025 17:51
@@ -26,6 +26,72 @@
"split": true,
"split_count": [35, 35]
},
"rgb_matrix": {
"driver": "ws2812",
"split_count": [29, 29],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The split_count config not matching the rgblight one looks rather suspect?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The board has 2 different RGB modes: a per key RGB, and a backlight-only mode. The board supports both being connected at the same time, but it's highly recommended not to as it will typically consume too much power for the USB bus.

(Almost) everybody who opts to use the per-key RGB matrix setup will not also have the backlight-only LEDs installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants