-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keyboard] Add RGB Matrix configuration to lotus58 #24820
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This should be added to the top keyboard level
info.json
file, so it is used by all revisions (since the only difference is microcontroller) - Please run
qmk format-json
on the file you modify (spaces instead of tabs, mostly)
4285399
to
533415e
Compare
Made the requested updates. I had originally had tabs for the change because that is what matched the rest of the formatting for the file. The top level |
@@ -26,6 +26,72 @@ | |||
"split": true, | |||
"split_count": [35, 35] | |||
}, | |||
"rgb_matrix": { | |||
"driver": "ws2812", | |||
"split_count": [29, 29], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The split_count
config not matching the rgblight one looks rather suspect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The board has 2 different RGB modes: a per key RGB, and a backlight-only mode. The board supports both being connected at the same time, but it's highly recommended not to as it will typically consume too much power for the USB bus.
(Almost) everybody who opts to use the per-key RGB matrix setup will not also have the backlight-only LEDs installed.
Description
Provide an RGB matrix for lotus58 keyboards.
Types of Changes
Issues Fixed or Closed by This PR
Checklist