Register for reflection Pageable class #45114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Can't we add something similar to what's in the reproducer to our spring integration tests? |
aureamunoz
force-pushed
the
register-pageable-4-reflection
branch
from
f40a608 to
5e49319
Compare
|
Done, this on is ready for review again @geoand |
This comment has been minimized.
This comment has been minimized.
|
The test failure looks related |
gsmet
requested changes
Dec 17, 2024
...tion-tests/spring-data-jpa/src/test/java/io/quarkus/it/spring/data/jpa/BookResourceTest.java
Outdated
Show resolved
Hide resolved
…attributes. Related to quarkusio#41292
aureamunoz
force-pushed
the
register-pageable-4-reflection
branch
from
5e49319 to
57c250d
Compare
gsmet
approved these changes
Dec 17, 2024
Status for workflow
|
geoand
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing paged/unpaged attributes in serialization. (See #41292 (comment)).
I've verified it works with the issue reproducer. However I'm not sure how to add a test for checking it automatically during the build.
cc @geoand