-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't treat colon as a permission-to-action separator in @PermissionChecker value attribute #45364
Don't treat colon as a permission-to-action separator in @PermissionChecker value attribute #45364
Conversation
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@sberyozkin could you have a look at this one? Probably something we want for 3.18. |
@michalvavrik @gsmet Sure, I was looking through PRs and I found I missed this one, sorry |
docs/src/main/asciidoc/security-authorize-web-endpoints-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-authorize-web-endpoints-reference.adoc
Outdated
Show resolved
Hide resolved
@michalvavrik Thanks for the fix, I'll let you decide in the next few hours how you'd like to deal with suggestions and then I'll merge, cheers |
474d17a
to
6f52091
Compare
Status for workflow
|
Status for workflow
|
@PermissionsAllowed
and@PermissionChecker
simple, because:
can be used inside claims etc. without having a special meaning (like the permission-to-actions separator); see linked issue@PermissionChecker
@PermissionChecker
is just a plain character@PermissionsAllowed
and@PermissionChecker
values are matched based on a string equality, no actions exist@PermissionsAllowed
attributeinclusive
is set totrue
andread
is granted by a permission checker, then all theread:all
,read:whatever
inside same annotation instancevalue
also require a permission checker; this is important because normally it would be one permission, not 3 checkers and it adds complexity