-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Never use wildcard imports #45372
Draft
punkratz312
wants to merge
43
commits into
quarkusio:main
Choose a base branch
from
punkratz312:add-editorconfig
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next, disable wildcard imports: navigate to Editor -> Code Style -> Java -> Imports and set Class count to use import with '*' to 999. Do the same with Names count to use static import with '*'.
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
punkratz312
changed the title
Add editorconfig
Add editorconfig to set Class count to use import with '*' to 999. Do the same with Names count to use static import with '*'.
Jan 8, 2025
@geoand is this helpful to avoid the manual interaction? |
punkratz312
changed the title
Add editorconfig to set Class count to use import with '*' to 999. Do the same with Names count to use static import with '*'.
cjhore: IntelliJ: Never use wildcard imports
Jan 14, 2025
punkratz312
changed the title
cjhore: IntelliJ: Never use wildcard imports
cjhore: Never use wildcard imports
Jan 14, 2025
punkratz312
changed the title
cjhore: Never use wildcard imports
chore: Never use wildcard imports
Jan 14, 2025
server properties no longer works with auto-config
This is done because I assume that was the original intent, but also because it avoids the non-zero cost incurred by Vert.x to look up the various supported options
They both have the same result starting with 23.1. Runtime initialization is public API while rerun is not, and will soon be deprecated and at some point removed in future releases. See oracle/graal#5013 (comment) and oracle/graal#8323
This change does not have any impact in Mandrel/GraalVM for JDK 21 and later versions, but allows Quarkus to build with Mandrel/GraalVM for JDK 17.
Starting with Mandrel/GraalVM for JDK 21 `RuntimeReinitializedClassBuildItem` is functionally the same with `RuntimeInitializedClassBuildItem`.
In a traditional blocking and synchronous framework the opentelemetry context is attached to ThreadLocal. In reactive programming, where multiple processings share the same event-loop thread, one has to use Vert.x duplicated contexts instead (see https://quarkus.io/guides/duplicated-context). wrapWithSpan ensures that the pipeline is executed on a duplicated context (If the current context already is duplicated, it will stay the same. Therefore, nested calls to wrapWithSpan will all run on the same vert.x context). inspired by Jan Peremsky (https://github.com/jan-peremsky/quarkus-reactive-otel/blob/c74043d388ec4df155f466f1d6938931c3389b70/src/main/java/com/fng/ewallet/pex/Tracer.java) and edeandrea (https://github.com/quarkusio/quarkus-super-heroes/blob/main/event-statistics/src/main/java/io/quarkus/sample/superheroes/statistics/listener/SuperStats.java) suggestions from review I will squash with the previous commit once everything is approved suggestion from reviewer todo: squash when everything is done -> adapt commit message. In this solution span and scope are local variables. no need for a stack. unnecessary line removed fix test to run on different contexts again cleanup
Add helper methods for manual spans in mutiny pipelines
…container Bump strimzi-test-container version from 0.107.0 to 0.109.1
Use VertxLogDelegateFactory for internal Vert.x logging
…eads This is going to be useful once netty/netty#14155 lands in Quarkus.
…-test-reuse-vertx-when-possible OIDC: reuse shared Vert.x instance in DEV and test mode whenever it is possible
…testclient-with-dev-svc-for-oidc OIDC: document and use OidcTestClient to get access token from Dev Services for OIDC
…rerun Switch to runtime initialization instead of rerun
punkratz312
commented
Jan 16, 2025
quarkus-bot
bot
added
area/gradle
Gradle
area/graphql
area/kafka
area/kubernetes
area/maven
area/platform
Issues related to definition and interaction with Quarkus Platform
area/smallrye
area/testing
area/tracing
area/vertx
labels
Jan 16, 2025
Next, disable wildcard imports: navigate to Editor -> Code Style -> Java -> Imports and set Class count to use import with '*' to 999. Do the same with Names count to use static import with '*'.
# Conflicts: # .editorconfig # pom.xml
quarkus-bot
bot
added
area/dependencies
Pull requests that update a dependency file
area/docstyle
issues related for manual docstyle review
area/documentation
area/kafka-streams
area/netty
area/oidc
labels
Jan 16, 2025
🎊 PR Preview 0a44026 has been successfully built and deployed to https://quarkus-pr-main-45372-preview.surge.sh/version/main/guides/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/amazon-lambda
area/arc
Issue related to ARC (dependency injection)
area/config
area/core
area/dependencies
Pull requests that update a dependency file
area/devtools
Issues/PR related to maven, gradle, platform and cli tooling/plugins
area/docstyle
issues related for manual docstyle review
area/documentation
area/funqy
area/gradle
Gradle
area/graphql
area/kafka
area/kafka-streams
area/kubernetes
area/maven
area/netty
area/oidc
area/platform
Issues related to definition and interaction with Quarkus Platform
area/smallrye
area/testing
area/tracing
area/vertx
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convention over configuration -> auto config over manual config:
Next, disable wildcard imports:
navigate to Editor -> Code Style -> Java -> Imports
and set Class count to use import with '*' to
999
. Do the same with Names count to use static import with '*'.https://stackoverflow.com/a/67844641/3388213
enforce with plugin: https://github.com/ec4j/editorconfig-maven-plugin
with * import
without *