Support java.util.Optional<T> passing to @QueryParam/@RestQuery for RestСlient

[lasteris]

• Closes: Support optional @QueryParam on Rest client #42623

[quarkus-bot]

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

• description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

_{This message is automatically generated by a bot.}

[geoand]

I'm not a huge fan of this, I would rather we return some string like key1=value1,value2/key2=value...

[lasteris]

I'm not a huge fan of this, I would rather we return some string like key1=value1,value2/key2=value...

No problem) I just decided that it would be more obvious that we are testing not a Map, but an Optional)

[lasteris]

I'm not a huge fan of this, I would rather we return some string like key1=value1,value2/key2=value...

fixed, pushed changes

[Ladicek]

Technically the type argument of Optional could also be an array.

EDIT: And a wildcard. Let's not get too wild with type variables :-)

[lasteris]

Sorry, i am tried to understand these mechanisms for hours, but still having some troubles :)
Do you mean, that i can just drop

if ((paramType.kind() == CLASS) || (paramType.kind() == PARAMETERIZED_TYPE)) {

and assign componentType directly to componentType = paramType.name().toString(); and that's safe ?
or i need to limit support of parameters type (exclude arrays and etc)

[Ladicek]

I honestly have no idea, I'm not familiar with this code at all. Just pointed out something that I saw while briefly going through this PR for no particular reason :-)

[geoand]

Indeed. At some point we might need to handle all the possible types, but we can keep that change for another day

[github-actions]

🙈 The PR is closed and the preview is expired.

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 4036dab.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4036dab.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

✖ io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

• expected: <1> but was: <2> - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:789)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)