New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing test assertion for different JVM's #931

Merged

chrjohn merged 1 commit into quickfix-j:master from the-thing:fix-test-assertion

Jan 17, 2025

Contributor

the-thing commented Jan 17, 2025 •

edited

Loading

Small SSL test improvements.

Changes

SNI algorithm should be set for two cases
Oracle JVM gives slightly different error message for quickfix.mina.ssl.SSLCertificateTest#shouldFailWhenHostnameDoesNotMatchServerName test case (error message is prepended with exception class name)

expected: "No name matching localhost found"
actual: "java.security.cert.CertificateException: No name matching localhost found"

I think there are different messages in JVM's higher than > 17 which might require changes in the future


          Fixing test assertion for different JVM's

369e783

chrjohn merged commit 9e81970 into quickfix-j:master

12 checks passed

chrjohn added this to the QFJ 3.0.0 milestone

Member

chrjohn commented Jan 17, 2025

Thank you

chrjohn mentioned this pull request

TLSv1.3 test #892

Draft

the-thing deleted the fix-test-assertion branch

January 18, 2025 08:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet