Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the for-each document from ISL #211

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

shhyou
Copy link
Collaborator

@shhyou shhyou commented Nov 16, 2023

This PR removes the documentation of for-each from ISL+, because it is actually part of ASL.

The new ISL+ for-each doc points to ASL.

@mfelleisen
Copy link
Contributor

I don't recall why for-each exists in ISL+.

In the spirit of Robby the czar of backwards compatibility, I recommend not to remove for-each from ISL+.

@shhyou
Copy link
Collaborator Author

shhyou commented Nov 17, 2023

@mfelleisen This PR only changes the document to point to ASL, basically removing examples that do not run. ISL+ itself stays as-is.

@shhyou
Copy link
Collaborator Author

shhyou commented Nov 17, 2023

Here is a screenshot of what this PR looks like.

Screenshot of this ISL+ for-each documentation PR

@mfelleisen
Copy link
Contributor

mfelleisen commented Nov 17, 2023 via email

@mfelleisen mfelleisen merged commit 48eb783 into master Nov 17, 2023
4 checks passed
@mfelleisen
Copy link
Contributor

mfelleisen commented Nov 17, 2023 via email

@shhyou shhyou deleted the remove-isl-for-each-doc branch November 17, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants