[RLlib] Split AddStates... connectors into 2 pieces (AddTimeDimToBatchAndZeroPad and AddStatesFromEpisodesToBatch)
#49835
+347
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_state_connectors_into_2
…t_state_connectors_into_2
sven1977
added
rllib
simonsays1980
approved these changes
Jan 15, 2025
| @@ -2977,6 +2977,16 @@ def log_result(self, result: ResultDict) -> None: | |||
|
|
|||
| @override(Trainable) | |||
| def cleanup(self) -> None: | |||
| # Stop all Learners. | |||
| if hasattr(self, "learner_group") and self.learner_group is not None: | |||
| self.learner_group.shutdown() | |||
There was a problem hiding this comment.
This does sometimes not work. At least in my workspace running on GPU a algo.stop() did not pull down the BackendExecutor workers.
…t_state_connectors_into_2
…nto split_state_connectors_into_2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
AddStates...connectors into 2 pieces (AddTimeDimToBatchAndZeroPadandAddStatesFromEpisodesToBatch)Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.