Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Run partial pre-commit rules in CI #49962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MortalHappiness
Copy link
Member

Why are these changes needed?

This PR runs the existing pre-commit hooks on all files in the CI. Other hooks will be enabled one by one in follow-up PRs, as enabling them will cause file changes.

Other hooks that are not enabled in this PR:

  • trailing-whitespace
  • end-of-file-fixer
  • check-json
  • python-no-log-warn
  • shellcheck
  • pretty-format-java

Once all hooks are enabled, they will be replaced by a single command pre-commit run --all-files --show-diff-on-failure, ensuring that all future pre-commit hooks are run in CI.

Related issue number

N/A

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MortalHappiness MortalHappiness added the go add ONLY when ready to merge, run all tests label Jan 20, 2025
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness force-pushed the feature/run-partial-pre-commit-rules branch from 02a65a2 to 9f8edb0 Compare January 20, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants