Use deref_pointer_as instead of deref_pointer

[geetanshjuneja]

Links to #3841.

This PR is still under progress.

[geetanshjuneja]

@RalfJung since libc isn't reliably available on Windows targets, I won't be able to get windows specificlayouts like this.libc_ty_layout("CONSOLE_SCREEN_BUFFER_INFO"). What should I do in this case?

[RalfJung]

Yeah CONSOLE_SCREEN_BUFFER_INFO is not in libc. It's a Windows API type. I'd say remove that one from the PR for now and open a Zulip thread; either we can find this type declaration somewhere else or we have to write some helpers to declare such struct types entirely ourselves.

[RalfJung]

Wait, did you add more deref_pointer → deref_pointer_as after my first review? Please don't do that, and especially please don't do that without explicitly posting a comment saying that you did! The general expectation is that once a review was done, the PR will not be extended in scope any more; all remaining changes are for resolving review concerns.

I will have to do a complete re-review, and since I am traveling this will take at least a week, maybe two.

[geetanshjuneja]

Wait, did you add more deref_pointer → deref_pointer_as after my first review? Please don't do that, and especially please don't do that without explicitly posting a comment saying that you did!

Sorry for not mentioning earlier that the PR is incomplete and making you review it unnecessarily. I have now made all the changes except for the windows part.

I will have to do a complete re-review, and since I am traveling this will take at least a week, maybe two.

I am not in a hurry, do re-review whenever you are free.