Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Identifier Syntax to Several Chapters #1597

Merged
merged 10 commits into from
Jan 14, 2025
Merged

Add Identifier Syntax to Several Chapters #1597

merged 10 commits into from
Jan 14, 2025

Conversation

chorman0773
Copy link
Contributor

This adds identifier syntax to:

  • keywords
  • lifetime-elision
  • macros
  • memory-allocation-and-lifetime
  • names
  • paths
  • patterns
  • runtime
  • special-types-and-traits

@chorman0773 chorman0773 added the T-spec Team: spec label Aug 30, 2024
@chorman0773 chorman0773 mentioned this pull request Sep 19, 2024
Open
90 tasks
@chorman0773 chorman0773 force-pushed the spec-add-identifiers-rest branch from 0e6e0ac to 572f23e Compare September 23, 2024 17:22
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Dec 3, 2024
@rustbot

This comment has been minimized.

Sign in to view
chorman0773 and others added 9 commits January 14, 2025 10:32
@chorman0773 @ehuss
Add identifier syntax to keywords, lifetime-elision, macros, memory-a…
af62fb0 
…llocation-and-lifetimes, names, and paths
@chorman0773 @ehuss
Add identifier syntax to patterns, runtime, and special-types-and-traits
de38b1b
@chorman0773 @ehuss
Fix duplicate pattern.wildcard
5d995b0
@chorman0773 @ehuss
Fix whitespace style issues in vmodified chapters
ed95833
@ehuss
Fix misspellings
f36e9d0
@ehuss
Rename this section
7c118ca 
It seems like there were two paragraphs, but one was about 'static and
the other was about something else. I decided to use a more generic term
for the section title.
@ehuss
Fix trailing space
96f57ca
@ehuss
Adjust rule names
cff9c6f 
Adjusts rule names for style, to fix some bugs, and to make some of them
more specific.
@ehuss
Adjust position of rules attached to headers
415cafe 
Adjusts the position of rules with headers to match the style from
rust-lang#1710
@ehuss ehuss force-pushed the spec-add-identifiers-rest branch from 8f2ef44 to 415cafe Compare January 14, 2025 18:44
ehuss
ehuss approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss enabled auto-merge January 14, 2025 18:45
@ehuss ehuss added this pull request to the merge queue Jan 14, 2025
Merged via the queue into rust-lang:master with commit 038c2e2 Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. T-spec Team: spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chorman0773 @rustbot @ehuss