Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mssql fixes #680

Closed
wants to merge 4 commits into from
Closed

Mssql fixes #680

wants to merge 4 commits into from

Conversation

Niivii
Copy link

@Niivii Niivii commented Sep 8, 2024

Should fix #678 #619 #354 #560 + a probably a bunch of others

@Niivii
Copy link
Author

Niivii commented Sep 11, 2024

Ok. Mandatroy disclaimer it's my first week coding in Rust and as I'm on Windows I couldn't make the tests runs because the profiling requires nix. I will setup a wsl or container and dig.

Didn't think UUID bump would break the tests.
@wangxiaoying Or could this just be because I forgot to bump the toml for connectorx-python ? 🤦

@wangxiaoying
Copy link
Contributor

Hi @Niivii , thanks for the PR! (sorry for the late reply)

Or could this just be because I forgot to bump the toml for connectorx-python ?
I just approved the CI running for this PR, let's see whether that's the issue.

Also, if you want to build and test offline on windows, here is the github workflow of how we build the wheel files for windows release. Hope it can be use as a reference.

@Niivii
Copy link
Author

Niivii commented Oct 1, 2024

Thanks a lot @wangxiaoying ! I will have a look and fix the postgres type test. Will probably have to modify it because of the UUID library bumps.

@Niivii
Copy link
Author

Niivii commented Nov 5, 2024

Closing this as a lot of changes has already been taken care of in 0.4.
I will reopen a new simpler PR just for SQL Server named instance issue and the pre login token supports (using_named_connection() + bump of tiberius to 0.9+).

@Niivii Niivii closed this Nov 5, 2024
@Niivii Niivii deleted the mssql-fixes branch November 5, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Tiberius to Latest Version (Fix Conversion Error)
2 participants