Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation error #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Samyak-Shreyash
Copy link

An indentation error @ Line52 in the matchmedia.js file in plugins located in the source directory was resulting in improper compilation of file.

An indentation error @ Line52 in the matchmedia.js file in plugins located in the source directory was resulting in improper compilation of file.
Copy link
Contributor

@JeanSebTr JeanSebTr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Samyak-Shreyash !

You seem to have added a new file instead of fixing the original, can you fix your PR?

Thanks

@udyux
Copy link
Contributor

udyux commented Sep 4, 2020

@JeanSebTr Just npm run lint and you're good to go. I dont have permission to push new branches but it's a quick fix.

@Aamirpal
Copy link

Hi @Samyak-Shreyash !

You seem to have added a new file instead of fixing the original, can you fix your PR?

Thanks

Hey @Samyak-Shreyash :
All you need to provide approprite space at line:52 and we are golden 🤩

Ref:
const operand = (!limit) ? '=='
: (limit === 'min') ? '<'
: '>'

@pixerize
Copy link

Hello, I really love this demo and I am new to Vue.js, I would like to build it locally to understand better how it works.
Npm install cannot complete. What can I do to make it run :)

Or even better if anyone has it created in the newer version of Vue.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants