Merge pull request #3 from spectrocloud/nianyu/fix-insecure

fix: respect remote options in save and remote-load
spectrocloud · Oct 22, 2024 · af461b1 · af461b1
2 parents 33e0af0 + 47e6941
commit af461b1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/cmd/cosign/cli/remote_load.go b/cmd/cosign/cli/remote_load.go
@@ -59,12 +59,12 @@ func RemoteLoadCmd(ctx context.Context, opts options.RemoteLoadOptions, src, dst
 		return err
 	}
 
-	se, err := ociremote.SignedEntity(srcRef)
+	ociremoteOpts, err := opts.Registry.ClientOpts(ctx)
 	if err != nil {
 		return err
 	}
 
-	ociremoteOpts, err := opts.Registry.ClientOpts(ctx)
+	se, err := ociremote.SignedEntity(srcRef, ociremoteOpts...)
 	if err != nil {
 		return err
 	}

diff --git a/cmd/cosign/cli/save.go b/cmd/cosign/cli/save.go
@@ -54,7 +54,10 @@ func SaveCmd(ctx context.Context, opts options.SaveOptions, imageRef string) err
 		return fmt.Errorf("parsing image name %s: %w", imageRef, err)
 	}
 
-	se, err := ociremote.SignedEntity(ref, ociremote.WithCachePath(opts.CachePath))
+	se, err := ociremote.SignedEntity(ref,
+		ociremote.WithCachePath(opts.CachePath),
+		ociremote.WithRemoteOptions(opts.Registry.GetRegistryClientOpts(ctx)...),
+	)
 	if err != nil {
 		return fmt.Errorf("signed entity: %w", err)
 	}