Adding Rector: Dead Code, Code quality, Coding Style, Type Declarations, Early return #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducting Rector and updating code for the configurarion:
```
->withPhpSets(php73: true)
->withPreparedSets(
deadCode: true,
codeQuality: true,
codingStyle: true,
typeDeclarations: true,
earlyReturn: true
);
```
RicLeP
reviewed
May 7, 2024
| $data = (string) $responseObj->getBody(); | ||
| $jsonResponseData = (array) json_decode($data, true); | ||
|
|
||
| // return response data as json if possible, raw if not | ||
| $result->httpResponseBody = $data && empty($jsonResponseData) ? $data : $jsonResponseData; | ||
| $result->httpResponseBody = $data && [] === $jsonResponseData ? $data : $jsonResponseData; |
There was a problem hiding this comment.
$data && $jsonResponseData === []
RicLeP
reviewed
May 7, 2024
| @@ -377,39 +362,30 @@ protected function getResponseExceptionMessage(ResponseInterface $responseObj) | |||
| { | |||
| $body = (string) $responseObj->getBody(); | |||
| $response = json_decode($body); | |||
| if (JSON_ERROR_NONE !== json_last_error()) { | |||
There was a problem hiding this comment.
if (json_last_error() !== JSON_ERROR_NONE) {
RicLeP
reviewed
May 7, 2024
| @@ -32,7 +32,7 @@ public function setBodyFromStreamInterface(StreamInterface $body): self | |||
| $data = (string) $body; | |||
| $jsonResponseData = (array) json_decode($data, true); | |||
| // return response data as json if possible, raw if not | |||
| $this->httpResponseBody = $data && empty($jsonResponseData) ? $data : $jsonResponseData; | |||
| $this->httpResponseBody = $data && [] === $jsonResponseData ? $data : $jsonResponseData; | |||
There was a problem hiding this comment.
$this->httpResponseBody = $data && $jsonResponseData === [] ? $data : $jsonResponseData;
|
Hi @RicLeP i see your comments, thank you! What do you think ? |
|
It’s a code style choice so not essential, however I think it’s usually recommended, but go with what you feel it best. :) |
|
Since PSR-12 its not recommended to use yoda style due to less readability of the code. However i prefer yoda style as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing Rector and updating the code for:
The configurarion:
Running all tests are still green