Update version of pylint to 3.3.3 #845
Open
+946
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a `.pylintrc` file that works with pylint 3.3.3. It started life as the config file produced by pylint 3.3.3 with the `--generate-rcfile` option. I then compared it to the previous `.pylintrc` and adjusted the settings to match, followed by a long period of test-adjust-retest: 1. run `pylint` on the existing code base 2. look at the warnings, find the relevant flags & turn them off 3. if there are more warnings, go back to step 1 This `.pylintrc` file thus has a lot of pylint checkers commented out. We should systematically re-enable the checkers and fix the warnings in the code. However, that should be left to separate PRs. This PR only makes the minimal changes needed to use pylint 3.3.3.
The `lint_all.sh` script invoked `pylint` with a couple of subdirectories, including `./examples`. However, that directory doesn't exist. Apparently Pylint version 2.4.4 didn't complain about this, but later versions of Pylint do.
mhucka
added
the
area/ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
requirements.txtto use Pylint version 3.3.3 and also updates.pylintrcsuch that it's compatible with 3.3.3 yet does not raise any new warnings in the code base. The intention of this PR is to make only the minimal changes needed to use pylint 3.3.3.The
.pylintrcstarted life as the config file produced by pylint 3.3.3 with the--generate-rcfileoption. I then compared it to the previous.pylintrcand adjusted the settings to match, followed by a long period of test-adjust-retest:pylinton the existing code baseThis
.pylintrcfile thus has a lot of pylint checkers commented out. We should systematically re-enable the checkers and fix the warnings in the code. However, that should be left to separate PRs.