Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Yarn install composite action remove --immutable-cache #9641

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

prastoin
Copy link
Contributor

@prastoin prastoin commented Jan 15, 2025

Encountered a false positive on the following run https://github.com/twentyhq/twenty/actions/runs/12790903292/job/35657751508
Checking for the cache

@prastoin prastoin marked this pull request as ready for review January 15, 2025 15:01
@charlesBochet charlesBochet merged commit d63aec4 into main Jan 15, 2025
31 of 32 checks passed
@charlesBochet charlesBochet deleted the yarn-install-remove-immutable-cache branch January 15, 2025 15:02
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Modified yarn install configuration by removing the --immutable-cache flag while retaining --immutable and --check-cache flags in the CI workflow.

  • Updated .github/workflows/actions/yarn-install/action.yaml to allow cache modifications during installation while maintaining lockfile integrity
  • Added yarn config set enableHardenedMode true for enhanced security during package installation
  • Improved caching strategy by using actions/cache/restore@v4 and actions/cache/save@v4 for node_modules

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-c0c6a1bd.json

Generated by 🚫 dangerJS against b0426d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants