feat: record group chevron button #9645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added a new AnimatedLightIconButton component that extends LightIconButton with Framer Motion animations, primarily used for record group chevron buttons.
- Added
packages/twenty-ui/src/input/button/components/AnimatedLightIconButton.tsxwith animation support via framer-motion ^11.18.0 - Duplicate
titleprop in AnimatedLightIconButtonProps (both explicit and in ComponentProps<'button'>) - Missing default case in accent color switch statement could lead to undefined colors
- Removed outline on focus in AnimatedLightIconButton may impact accessibility
- Replaced custom motion.span with AnimatedLightIconButton in RecordTableRecordGroupSection while maintaining animation behavior
6 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+11
to
+23
| export type AnimatedLightIconButtonProps = { | ||
| className?: string; | ||
| testId?: string; | ||
| Icon?: IconComponent; | ||
| title?: string; | ||
| size?: LightIconButtonSize; | ||
| accent?: LightIconButtonAccent; | ||
| active?: boolean; | ||
| disabled?: boolean; | ||
| focus?: boolean; | ||
| onClick?: (event: MouseEvent<HTMLButtonElement>) => void; | ||
| } & Pick<ComponentProps<'button'>, 'aria-label' | 'title'> & | ||
| Pick<MotionProps, 'animate' | 'transition'>; |
There was a problem hiding this comment.
logic: title prop is duplicated - it appears in both the explicit props and ComponentProps<'button'> Pick
Comment on lines
+91
to
+97
| <AnimatedLightIconButton | ||
| Icon={IconChevronDown} | ||
| size="small" | ||
| accent="secondary" | ||
| animate={{ rotate: !isRecordGroupTableSectionToggled ? -90 : 0 }} | ||
| transition={{ duration: theme.animation.duration.normal }} | ||
| style={{ | ||
| display: 'inline-block', | ||
| }} | ||
| > | ||
| <IconChevronDown size={theme.icon.size.md} /> | ||
| </motion.span> | ||
| /> |
There was a problem hiding this comment.
logic: missing aria-label for accessibility on the button that controls expanding/collapsing the section
Comment on lines
88
to
89
| <StyledTrContainer onClick={handleDropdownToggle}> | ||
| <td aria-hidden /> |
There was a problem hiding this comment.
style: consider adding role='row' to StyledTrContainer for better accessibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket is related to this Discord post https://discord.com/channels/1130383047699738754/1328756649657110559