Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation + docker-compose.yml update #9653

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

BOHEUS
Copy link
Contributor

@BOHEUS BOHEUS commented Jan 15, 2025

Related to #9469 #9455 #9419 #8943

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates documentation to improve clarity around Docker Compose usage and version upgrades, addressing several reported issues and user feedback.

  • Added explicit instructions in upgrade guide about sequential version upgrades (e.g. 0.31.0 -> 0.32.0 -> 0.33.0)
  • Updated all instances of docker-compose to docker compose to align with current Docker CLI syntax
  • Added migration guidance between postgres container types (bitnami to spilo) in /packages/twenty-website/src/content/developers/self-hosting/upgrade-guide.mdx
  • Enhanced troubleshooting documentation with solutions from Discord help channel feedback
  • Improved SSL and external access configuration details in Docker Compose guide

5 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -16,7 +16,7 @@ For example, if you have a page that listens for the Enter key, and a modal that

To handle this problem, we have a custom hook that makes it possible to listen to hotkeys without any conflict.

You place it in a component and it will listen to the hotkeys only when the component is mounted AND when the specified **hotkey scope** is active.
You place it in a component, and it will listen to the hotkeys only when the component is mounted AND when the specified **hotkey scope** is active.

## How to listen for hotkeys in practice ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: question mark after 'practice' is informal - consider removing

Comment on lines 161 to 162
docker compose down
docker compose up -d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: unnecessary indentation in code block - remove leading spaces

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BOHEUS!

@charlesBochet charlesBochet merged commit 34ddead into twentyhq:main Jan 16, 2025
32 checks passed
Copy link

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-660f804a.json

Generated by 🚫 dangerJS against d6a7402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants