Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open showpage on workflow creation #9714

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

bosiraphael
Copy link
Contributor

@bosiraphael bosiraphael commented Jan 17, 2025

  • Created an new component state isRecordEditableNameRenamingComponentState
  • Updated useCreateNewTableRecord to open the ShowPage on workflow creation
  • Refactored RecordEditableName and its components to remove the useEffect (This was causing the recordName state to be updated after the focus on NavigationDrawerInput, but we want the text so be selected after the update).
  • Introduced a new component NavigationDrawerItemInput which contains NavigationDrawerInput and NavigationDrawerItem
Enregistrement.de.l.ecran.2025-01-17.a.14.03.12.mov

Copy link

sentry-io bot commented Jan 17, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/twenty-front/src/pages/object-record/RecordShowPage.tsx

Function Unhandled Issue
RecordShowPage Error: Object metadata item "skill" cannot be found in an array of 37 elements ...
Event Count: 1 Affected Users: 3

Did you find this useful? React with a 👍 or 👎

Copy link

github-actions bot commented Jan 17, 2025

TODOs/FIXMEs:

  • // TODO: Generalize this behaviour, there will be a view setting to specify: packages/twenty-front/src/modules/object-record/record-table/hooks/useCreateNewTableRecords.ts

Generated by 🚫 dangerJS against 20872e9

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances workflow record creation by redirecting to a dedicated show page with immediate name editing functionality, while improving the record renaming system.

  • Added isRecordEditableNameRenamingComponentState for managing record name editing state with Recoil
  • Modified useCreateNewTableRecord to navigate to show page for new workflow records instead of command menu
  • Refactored RecordEditableName to fix text selection issues by removing useEffect and local state
  • Created new NavigationDrawerItemInput component to handle seamless switching between display/edit modes
  • Added RecordComponentInstanceContext for scoped state management in record-related components

7 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant