-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open showpage on workflow creation #9714
base: main
Are you sure you want to change the base?
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: packages/twenty-front/src/pages/object-record/RecordShowPage.tsx
Did you find this useful? React with a 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR enhances workflow record creation by redirecting to a dedicated show page with immediate name editing functionality, while improving the record renaming system.
- Added
isRecordEditableNameRenamingComponentState
for managing record name editing state with Recoil - Modified
useCreateNewTableRecord
to navigate to show page for new workflow records instead of command menu - Refactored
RecordEditableName
to fix text selection issues by removing useEffect and local state - Created new
NavigationDrawerItemInput
component to handle seamless switching between display/edit modes - Added
RecordComponentInstanceContext
for scoped state management in record-related components
7 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
isRecordEditableNameRenamingComponentState
useCreateNewTableRecord
to open the ShowPage on workflow creationRecordEditableName
and its components to remove the useEffect (This was causing the recordName state to be updated after the focus onNavigationDrawerInput
, but we want the text so be selected after the update).NavigationDrawerItemInput
which containsNavigationDrawerInput
andNavigationDrawerItem
Enregistrement.de.l.ecran.2025-01-17.a.14.03.12.mov