Make AggregateFooter on top if table isScrollable #9721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the scroll behavior and positioning of the aggregate footer in the record table by integrating OverlayScrollbars instance management and simplifying container structure.
- Added
instanceproperty toScrollWrapperContextValuein/packages/twenty-front/src/modules/ui/utilities/scroll/contexts/ScrollWrapperContexts.tsxfor scroll control - Removed nested container structure and height constraints in
/packages/twenty-front/src/modules/object-record/record-table/components/RecordTableWithWrappers.tsx - Added problematic debug console.log statements in
/packages/twenty-front/src/modules/object-record/record-table/record-table-body/components/RecordTableBodyFetchMoreLoader.tsx - Simplified
ScrollWrappercomponent by removingStyledInnerContainerand exposing OverlayScrollbars instance
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+61
to
+66
| if (scrollWrapperRef.instance !== null) { | ||
| console.log( | ||
| (scrollWrapperRef.instance as any)().elements().content.scrollHeight, | ||
| (scrollWrapperRef.instance as any)().elements().content.clientHeight, | ||
| ); | ||
| } |
There was a problem hiding this comment.
style: Debug console.log should not be committed to production code. Consider using a debug flag or removing entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.