Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E][CI] Setup Playwright webServer #9730

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[E2E][CI] Setup Playwright webServer #9730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51af668
nitpick(e2e): replace yarn usage by npx
prastoin Jan 17, 2025
9eb5b3c
feat(e2e): define front and server webservers
prastoin Jan 17, 2025
fb685f8
refactor(e2e): remove start front & worker & server start steps in ci
prastoin Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions .github/workflows/ci-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,23 +87,6 @@ jobs:
PGPASSWORD=postgres psql -h localhost -p 5432 -U postgres -d postgres -c 'CREATE DATABASE "default";'
PGPASSWORD=postgres psql -h localhost -p 5432 -U postgres -d postgres -c 'CREATE DATABASE "test";'
npx nx run twenty-server:database:reset

- name: Start server
run: |
npx nx start twenty-server &
echo "Waiting for server to be ready..."
timeout 60 bash -c 'until curl -s http://localhost:3000/health; do sleep 2; done'

- name: Start frontend
run: |
npm_config_yes=true npx serve -s packages/twenty-front/build -l 3001 &
echo "Waiting for frontend to be ready..."
timeout 60 bash -c 'until curl -s http://localhost:3001; do sleep 2; done'

- name: Start worker
run: |
npx nx run twenty-server:worker:ci &
echo "Worker started"

- name: Install Playwright Browsers
run: npx nx setup twenty-e2e-testing
Expand Down
46 changes: 21 additions & 25 deletions packages/twenty-e2e-testing/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,27 @@ export default defineConfig({
slowMo: 500, // time in milliseconds between each step, better to use it than explicitly define timeout in tests
},
},
webServer: [
// Comment from now as I don't how to get worker's healthcheck
// {
// command: 'npx nx worker twenty-server',
// url: 'http://127.0.0.1:3001',
// timeout: 120 * 1000,
// reuseExistingServer: !process.env.CI,
// },
{
command: 'npx nx start twenty-server',
url: 'http://localhost:3000/healthz',
timeout: 120 * 1000,
reuseExistingServer: !process.env.CI,
},
{
command: 'npx nx start twenty-front',
url: 'http://localhost:3001',
timeout: 120 * 10000,
reuseExistingServer: !process.env.CI,
}
],
expect: {
timeout: 5000,
},
Expand All @@ -60,30 +81,5 @@ export default defineConfig({
dependencies: ['Login setup'],
testMatch: /authentication\/.+\.e2e-spec\.ts/, // forces to run login setup before running tests from this project - CASE SENSITIVE
},

//{
// name: 'webkit',
// use: { ...devices['Desktop Safari'] },
//},

/* Test against mobile viewports. */
// {
// name: 'Mobile Chrome',
// use: { ...devices['Pixel 5'] },
// },
// {
// name: 'Mobile Safari',
// use: { ...devices['iPhone 12'] },
// },

/* Test against branded browsers. */
//{
// name: 'Microsoft Edge',
// use: { ...devices['Desktop Edge'], channel: 'msedge' },
//},
//{
// name: 'Google Chrome',
// use: { ...devices['Desktop Chrome'], channel: 'chrome' },
//},
],
});
10 changes: 5 additions & 5 deletions packages/twenty-e2e-testing/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"options": {
"cwd": "packages/twenty-e2e-testing",
"commands": [
"yarn playwright install"
"npx playwright install --with-deps"
]
}
},
Expand All @@ -17,7 +17,7 @@
"options": {
"cwd": "packages/twenty-e2e-testing",
"commands": [
"yarn playwright test"
"npx playwright test"
]
}
},
Expand All @@ -26,7 +26,7 @@
"options": {
"cwd": "packages/twenty-e2e-testing",
"commands": [
"yarn playwright test --ui"
"npx playwright test --ui"
]
}
},
Expand All @@ -35,7 +35,7 @@
"options": {
"cwd": "packages/twenty-e2e-testing",
"commands": [
"yarn playwright test --debug"
"DEBUG=pw:webserver npx playwright test --debug"
]
}
},
Expand All @@ -44,7 +44,7 @@
"options": {
"cwd": "packages/twenty-e2e-testing",
"commands": [
"yarn playwright show-report"
"npx playwright show-report"
]
}
}
Expand Down
Loading