-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement] replace NTHREADS
threading control with MAKEFLAGS
, remove daal4py extension build parallelization
#2240
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
/intelci: run |
/intelci: run |
/intelci: run |
/intelci: run |
max_jobs
build environment variable
max_jobs
build environment variableMAX_JOBS
build environment variable
NTHREADS
threading control with MAKEFLAGS
, fix parallelization in daal4py extension buildNTHREADS
threading control with MAKEFLAGS
, remove daal4py extension build parallelization
@icfaust I'm seeing one issue now which doesn't happen in the master branch: a call to |
On a second look: perhaps it could be because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending CI results.
/intelci: run |
Description
Follow on from #1196 which solves a leftover todo. This sets the cmake processes and cythonize multithreading based on the
MAKEFLAGS
-j
flag. Written in a way that if a command line argument-j 2
is given, it will overrideMAKEFLAGS
, but still maintains a default of the number of cpus if flag is not set inMAKEFLAGS
.Secondly, the parallelization of daal4py building was not possible with the previous code, and is not possible without significant rework. The custom
build_ext
setuptools Command object is replaced by the Cython version to extend capabilities in daal4py building.Changes reduce building on github actions for DPC++ builds by 2-3 minutes, probably because the previous metric limited the number of processes.
No performance benchmarks necessary
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance