Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2nd attempt at finalizing list of Editors, Authors, and Acknowledgements. #1585

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

msporny
Copy link
Member

@msporny msporny commented Jan 19, 2025

PR #1579 finalized the list of Editors, Authors, and Acknowledgements, was discussed during a WG call and was merged.

The WG Chair has reverted that merge in PR #1584 suggesting a different understanding for how Editor's would be credited on WG specifications.

This PR finalizes the list of Editors, Authors, and Acknowledgements according to that new understanding such that it can be reviewed by the WG during the next call.


Preview | Diff

msporny and others added 5 commits January 19, 2025 14:16
Co-authored-by: Orie Steele <orie@or13.io>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Brian Campbell <71398439+bc-pi@users.noreply.github.com>
@msporny msporny added editorial Purely editorial changes to the specification. CR2 labels Jan 19, 2025
Comment on lines +7662 to +7663
a sea of varied opinions: David Chadwick, Dave Longley,
Ted Thibodeau Jr., Brent Zundel, Ivan Herman, and Joe Andrieu.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
a sea of varied opinions: David Chadwick, Dave Longley,
Ted Thibodeau Jr., Brent Zundel, Ivan Herman, and Joe Andrieu.
a sea of varied opinions: Brent Zundel, Dave Longley, David Chadwick,
Gabe Cohen, Ivan Herman, Joe Andrieu, and Ted Thibodeau Jr.

Alphabetize by first name and add @decentralgabe, in light of his leadership in conceiving of, socializing, and obtaining consensus to pass the Miami resolution, which gave us a "big-tent" model of Verifiable Credentials. Gabe was also instrumental in negotiations enabling us to consistently use media type names based on "vc" and "vp" across the family of specifications.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list is sorted in order of the count and volume of comments the individual has contributed. I have no objection to adding Gabe if the group feels that he doesn't have to meet the same requirements of the others in the list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the requirements that you are referring to, @msporny? They are currently unstated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment score greater than 500 for this specification:

#1579 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leadership in a working group is manifested in many ways not reflected in the scores. Both of the demonstrations of leadership I cited motivating @decentralgabe's inclusion in this list (the Miami resolution, the media type negotiations) are not captured by these scores, but both were significant to the progress of this specification and the consensus behind it. Gabe clearly meets the bar of performing "yeoman's work in this standards community that drove changes, discussion, and consensus among a sea of varied opinions".

Also, I'll note that a cursory look at the data posted demonstrates that the methodology used is significantly flawed. For instance, Tony Nadalin had a higher score than many significant contributors to the 2.0 effort, even though he barely participated in 2.0, if at all. (Please do not interpret this remark as a slight on Tony, who I respect.) It is simply a concrete example of the data used to generate these scores not matching what actually occurred.

Anil John,
Anthony Camilleri,
Anthony Nadalin,
ashimura,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ashimura,

Duplicate of Kazuyuki Ashimura.

Bumblefudge,
Butters,
caribouW3,
cdr,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cdr,

It makes little sense to acknowledge people who cannot be identified by the text in the acknowledgements.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single names are github handles, we should not remove them just because they have chosen not to share their full name (same comments for all of the below):

https://github.com/cdr/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the working group is willing to acknowledge anonymous contributors by their GitHub handles, then these acknowledgements should be moved to a separate list and identified as such. I suggest this text as the preface to this list:

The following GitHub accounts anonymously made contributions to this specification:

For extra credit, the entries in this list can be links to the corresponding GitHub accounts. For instance "cdr" would be a link to https://github.com/cdr/.

The current description of these entries being sorted by their first names is incorrect.

Christopher Lemmer Webber,
ckennedy422,
Clare Nelson,
confiks,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
confiks,

Ditto about the proposed text in the acknowledgements not identifying the contributor.

Devin Rousso,
Dmitri Zagidulin,
Dominique Hazael-Massieux,
Dostkamp,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Dostkamp,

Ditto

Dominique Hazael-Massieux,
Dostkamp,
Drummond Reed,
Elliott,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Elliott,

Duplicate of Eric Elliott.

Elliott,
Emmanuel,
enuoCM,
Eric,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Eric,

Duplicate of Eric Elliott.

Dostkamp,
Drummond Reed,
Elliott,
Emmanuel,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Emmanuel,

Text does not identify the contributor.

Eric Elliott,
Eric Korb,
Eric Prud'hommeaux,
etaleo,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
etaleo,

Ditto.

Grant Noble,
Greg Bernstein,
Gregg Kellogg,
Haber,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Haber,

Ditto.

Henry Andrews,
Henry Story,
Ian B. Jacobs,
Ilan,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ilan,

Ditto.

Ian B. Jacobs,
Ilan,
Isaac Henderson,
isaackps,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isaackps,

Ditto.

Ken Ebert,
Kendall Weihe,
Kerri Lemoie,
Kevin,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Kevin,

Likely a duplicate of one of the Kevins below. Also, does not identify the contributor.

Kristina Yasuda,
Kyle Den Hartog,
Lal Chandran,
Lance,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Lance,

Text does not identify the contributor.

Mike Varley,
Mircea Nistor,
MIZUKI Sonoko / Igarashi,
nage,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nage,

Ditto.

Rieks Joosten,
RorschachRev,
Ryan Grant,
Samu,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Samu,
Samuel Müller,

Steve Huguenin,
Steve McCown,
Steven Rowat,
Taro,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Taro,

Ditto.

Steve McCown,
Steven Rowat,
Taro,
tcibm,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tcibm,

Ditto.

Vladimir Alexiev,
Víctor Herraiz Posada,
Wayne Chang,
whatisthejava,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
whatisthejava,

Ditto.

Brian Richter,
Bruno Zimmermann,
Bumblefudge,
Butters,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Butters,

Text does not identify the contributor.

Torsten Lodderstedt,
Tzviya Siegman,
Victor Dods,
vieillevigne,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vieillevigne,

Ditto.

Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @msporny. I made a few suggestions. I will approve after they have been incorporated.

While I commented on new proposed acknowledgements that do not identify the contributor, I did not suggest removing existing ones. That said, the working group should determine whether to keep these existing acknowledgements that also do not identify their contributors:

Bumblefudge
caribouW3
Chaoxinhu
ckennedy422
enuoCM
Iso5786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR2 editorial Purely editorial changes to the specification.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants