[Accelerator 4] Changing regulatory property to Fapi complaint to match IS property #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VimukthiRajapaksha
approved these changes
Jan 16, 2025
imesh94
reviewed
Jan 16, 2025
| @@ -135,7 +135,7 @@ public static String reduceStringLength(String input, int maxLength) { | |||
| * @throws RequestObjectException If an error occurs while checking the client ID | |||
| */ | |||
| @Generated(message = "Excluding from code coverage since it requires a service call") | |||
| public static boolean isRegulatoryApp(String clientId) throws RequestObjectException { | |||
| public static boolean isFapiConformantApp(String clientId) throws RequestObjectException { | |||
There was a problem hiding this comment.
Shall we update the method comment as well?
imesh94
reviewed
Jan 16, 2025
| @@ -153,6 +153,6 @@ protected String getAllowedScopes(OAuth2Parameters oAuth2Parameters) throws Requ | |||
| @Generated(message = "Excluding from code coverage since it requires a service call") | |||
| protected boolean isRegulatory(OAuth2Parameters oAuth2Parameters) throws RequestObjectException { | |||
There was a problem hiding this comment.
Shouldn't we update this method identifier?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Accelerator 4] Changing regulatory property to Fapi complaint to match IS property
Issue link: required
Doc Issue: Optional, link issue from documentation repository
Applicable Labels: Spec, product, version, type (specify requested labels)
Development Checklist
Testing Checklist