Refactor opa filter tests to use specific rules #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pushpalanka
force-pushed
the
refactor-opa-tests
branch
from
6d839e6 to
b91f213
Compare
Pushpalanka
force-pushed
the
refactor-opa-tests
branch
2 times, most recently
from
9d23b10 to
85dbae0
Compare
Pushpalanka
force-pushed
the
refactor-opa-tests
branch
4 times, most recently
from
add7c43 to
e0bea8e
Compare
Pushpalanka
changed the title
Pushpalanka
force-pushed
the
refactor-opa-tests
branch
2 times, most recently
from
68a0251 to
6ebdb9e
Compare
Signed-off-by: Pushpalanka Jayawardhana <pushpalanka.jayawardhana@zalando.de>
Pushpalanka
force-pushed
the
refactor-opa-tests
branch
from
6ebdb9e to
cbf7aa0
Compare
Pushpalanka
requested review from
JanardhanSharma,
mjungsbluth and
mefarazath
and removed request for
mjungsbluth and
JanardhanSharma
|
👍 |
|
Thanks tests are more readable now! |
|
👍 |
This was referenced Jan 9, 2025
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jan 15, 2025
* zalando/skipper#3358 * zalando/skipper#3357 * zalando/skipper#3359 * zalando/skipper#3311 * zalando/skipper#3361 * zalando/skipper#3267 * zalando/skipper#3363 * zalando/skipper#3313 See: * [changes](zalando/skipper@v0.21.240...v0.21.247) * #8748 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Pending : HTTP2 headers are not tested as of yet. An internal ticket is present to address this.