Upgrade to OPA v0.70.0 #3374
Upgrade to OPA v0.70.0 #3374
Conversation
Pushpalanka
force-pushed
the
opa-v0.70.0
branch
from
5378968 to
f121a57
Compare
Pushpalanka
requested review from
mjungsbluth,
mefarazath,
MustafaSaber and
AlexanderYastrebov
| @@ -74,6 +75,8 @@ type OpenPolicyAgentRegistry struct { | |||
| bodyReadBufferSize int64 | |||
|
|
|||
| tracer opentracing.Tracer | |||
|
|
|||
| preevaluationOptimization bool | |||
There was a problem hiding this comment.
This needs to be removed
Pushpalanka
force-pushed
the
opa-v0.70.0
branch
from
cc8fb1a to
ae35ee6
Compare
|
Can you add in the PR description a small comment about the breaking change and what is done to fix it? I understand if I read code I can figure that out but would be also great to figure from commit message |
Addressed. 👍 |
|
👍 |
|
The changes related to the OPA use LGTM 👍 , Alexander's comment should still be addressed and there seems to be a merge conflict. |
Pushpalanka
force-pushed
the
opa-v0.70.0
branch
2 times, most recently
from
789e4ad to
eac57bd
Compare
|
@Pushpalanka Please squash it into a single commit with a proper title and description. The thing is that build pipeline automatically creates release notes out of it. |
The EvalContext interface is added with new CreatePreparedQueryOnce function and the signature of envoyauth.Eval(ctx, opa, inputValue, result) method used by Skipper were changed with in OPA v0.70.0 as a result of open-policy-agent/opa-envoy-plugin#604. The interface change is absorbed with no functional addition and just addressing successful compilation. Signed-off-by: Pushpalanka Jayawardhana <pushpalanka.jayawardhana@zalando.de>
Pushpalanka
force-pushed
the
opa-v0.70.0
branch
from
eac57bd to
426d997
Compare
Addressed 👍 |
|
👍 |
|
@Pushpalanka Thank you |
|
👍 |
Make use of OPA v0.70.0 version, addressing the breaking change.
Breaking change context
The
EvalContextinterface is added with newCreatePreparedQueryOncefunction and the signature ofenvoyauth.Eval(ctx, opa, inputValue, result)method used by Skipper were changed with in OPA v0.70.0 as a result of open-policy-agent/opa-envoy-plugin#604.This has been done to support a cleaner optimization we look forward to use with PreparedQuery(transforming the Rego query to an intermediate state that is reused with different inputs, removing the repeated steps of parsing and compiling) option in the future.
The interface change is absorbed with no functional addition and just addressing successful compilation.
Notes:
Until the pre-evaluation based optimization is properly benchmarked, it is not supported to be enabled via configs. Only the breaking change for compilation is addressed.
Styra is already on this version.