Fix labwc-9999 build failing due to missing libsfdo #112
Conversation
BGazotti
changed the title
|
Second on this because of todays commit labwc/labwc@3a4e0cf which version bumped it up to the version you made for the ebuild you made. |
|
Also labwc's version has been bumped to 0.8.1 labwc/labwc@6bd36e8 So the versioned ebuilds can also be updated. |
| @@ -0,0 +1,24 @@ | |||
| # Copyright 2024 Gentoo Authors | |||
| # Distributed under the terms of the GNU General Public License v2-or-later | |||
There was a problem hiding this comment.
This should be changed to the ISC license as per the licensing policy. Take a look at the main labwc ebuild how it's been done :)
|
Looking through this properly now that I have more time as well, the libsfdo ebuild needs an accompanying metadata.xml. Testing this locally, I ran To placate pkgcheck, you could change the .tar.gz to .tar.bz2. The DEPEND and BDEPEND lines aren't necessary so they can simply get removed. I may also soon send @epsilon-0 an e-mail asking what's happening since this has been a PR for a few months now. I hope they're doing ok. |
| KEYWORDS="~amd64" | ||
|
|
||
| DEPEND="" | ||
| RDEPEND="${DEPEND}" |
There was a problem hiding this comment.
DEPEND and RDEPEND aren't doing anything so you can get rid of these lines.
|
|
||
| DESCRIPTION="A collection of libraries which implement some freedesktop.org specifications" | ||
| HOMEPAGE="https://gitlab.freedesktop.org/vyivel/libsfdo" | ||
| SRC_URI="https://gitlab.freedesktop.org/vyivel/libsfdo/-/archive/v${PV}/libsfdo-v${PV}.tar.gz" |
There was a problem hiding this comment.
pkgcheck is saying that .tar.bz2 is more efficient so it's probably worth grabbing that format.
There was a problem hiding this comment.
bz2 is indeed more space-efficient, but decompresses slower. Shouldn't make a difference for such a small file though
There was a problem hiding this comment.
Agreed, it's probably the least important out of the 3 things.
use .bz2 distfile for lower disk and network overhead update license and copyright information
Labwc added support for window icons in labwc/labwc@a745f91, using libsfdo.
That feature is enabled by default and will result in a configure error if that library isn't found.
Commits add a very crude but working ebuild for gui-libs/libsfdo and the 'icons' USE flag to labwc to enable optionally building that feature.
Alternatively, we could just add the libsfdo tarball to the ebuild as an exception for the network sandbox and allow labwc's meson scripts to build and bundle it.