Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labwc-9999 build failing due to missing libsfdo #112

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gui-libs/libsfdo/Manifest
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
DIST libsfdo-v0.1.3.tar.gz 53720 BLAKE2B f89502b0bcc5029a693808f5390e821a92852da17a716974e81a114069b65795b3f67dd018e0459d139521efb44252d55f6518952d6cd0def9e74b8931ae2aaf SHA512 4ea944ce58687a70930b49124af5bc4d8e590dbf0b29094d2ef7f405ee3e6e0e24f090ba292c003073551f4cb9713476b4ee3b6ac8f00da28a11312bbe6a3208
24 changes: 24 additions & 0 deletions gui-libs/libsfdo/libsfdo-0.1.3.ebuild
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Copyright 2024 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2-or-later
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to the ISC license as per the licensing policy. Take a look at the main labwc ebuild how it's been done :)


EAPI=8

DESCRIPTION="A collection of libraries which implement some freedesktop.org specifications"
HOMEPAGE="https://gitlab.freedesktop.org/vyivel/libsfdo"
SRC_URI="https://gitlab.freedesktop.org/vyivel/libsfdo/-/archive/v${PV}/libsfdo-v${PV}.tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgcheck is saying that .tar.bz2 is more efficient so it's probably worth grabbing that format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bz2 is indeed more space-efficient, but decompresses slower. Shouldn't make a difference for such a small file though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, it's probably the least important out of the 3 things.


# necessary because packaged dir contains a v before version number
S="${WORKDIR}/${PN}-v${PV}"

LICENSE="BSD-2"
SLOT="0"
KEYWORDS="~amd64"

DEPEND=""
RDEPEND="${DEPEND}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEPEND and RDEPEND aren't doing anything so you can get rid of these lines.

BDEPEND="
dev-build/meson
virtual/pkgconfig
"

inherit meson
4 changes: 3 additions & 1 deletion gui-wm/labwc/labwc-9999.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ fi

LICENSE="GPL-2"
SLOT="0"
IUSE="+nls +svg +X"
IUSE="icons +nls +svg +X"

RDEPEND="
dev-libs/glib:2
Expand All @@ -31,6 +31,7 @@ RDEPEND="
x11-libs/libxkbcommon:=[X?]
x11-libs/pango[X?]
x11-libs/pixman
icons? ( >=gui-libs/libsfdo-0.1.3 )
nls? ( sys-devel/gettext )
svg? ( >=gnome-base/librsvg-2.46 )
X? ( x11-libs/libxcb:0= )
Expand All @@ -48,6 +49,7 @@ PATCHES=(

src_configure() {
local emesonargs=(
$(meson_feature icons icon)
$(meson_feature X xwayland)
$(meson_feature nls)
$(meson_feature svg)
Expand Down
Loading