Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto(invite|signin): remove unused code + fix signin on invite page. #9745

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

AMoreaux
Copy link
Contributor

@AMoreaux AMoreaux commented Jan 20, 2025

  • Replace window.location.replace by useRedirect hook.
  • Remove unused code: switchWorkspace, addUserByInviteHash...
  • Refacto Invite component.
  • Fix signin on invite modal.

@AMoreaux AMoreaux self-assigned this Jan 20, 2025
Eliminates the SwitchWorkspace functionality, including its service, DTO, and related resolver logic. This cleanup removes unused code and simplifies the auth module structure.
Removed the `switchWorkspace` mutation and its associated arguments from the GraphQL schema. This code was unused and its removal helps in cleaning up the generated types and mutations.
Introduced the `timeoutSeconds` field in various types and mutations related to ServerlessFunction. This allows setting a timeout for serverless functions, providing more configurability for function execution limits.
Removed obsolete mutations and related logic for adding users to workspaces via invite tokens or hashes. Replaced old `window.location.replace` calls with the `redirect` hook across affected files to improve maintainability and consistency.
…-signin-on-invite-page' into chore/remove-unused-code-and-fix-signin-on-invite-page
@AMoreaux AMoreaux requested a review from Weiko January 20, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant