-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refacto(invite|signin): remove unused code + fix signin on invite page. #9745
Open
AMoreaux
wants to merge
12
commits into
main
Choose a base branch
from
chore/remove-unused-code-and-fix-signin-on-invite-page
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f907774
WIP
AMoreaux ac80646
remove unused code
AMoreaux 3641c30
Merge remote-tracking branch 'origin/main' into chore/remove-unused-c…
AMoreaux 501d5a8
refactor(auth): remove SwitchWorkspace feature
AMoreaux bbd4a21
refactor(graphql): remove unused switchWorkspace mutation
AMoreaux d153a49
feat(graphql): add timeoutSeconds field to ServerlessFunction
AMoreaux 4a7c653
Merge branch 'main' into chore/remove-unused-code-and-fix-signin-on-i…
AMoreaux 063c0d1
refactor(auth): remove deprecated workspace invite mutations
AMoreaux 6803ed7
Merge remote-tracking branch 'origin/chore/remove-unused-code-and-fix…
AMoreaux 5f50e05
Merge branch 'main' into chore/remove-unused-code-and-fix-signin-on-i…
AMoreaux 201f9a5
refactor(auth, settings): remove unused state and debug log
AMoreaux 9605bfb
refactor(auth): remove unused Recoil dependency
AMoreaux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 0 additions & 23 deletions
23
packages/twenty-front/src/modules/auth/graphql/mutations/switchWorkspace.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,13 +6,13 @@ export const useBuildWorkspaceUrl = () => { | |
const domainConfiguration = useRecoilValue(domainConfigurationState); | ||
|
||
const buildWorkspaceUrl = ( | ||
subdomain?: string, | ||
subdomain: string, | ||
pathname?: string, | ||
searchParams?: Record<string, string>, | ||
) => { | ||
const url = new URL(window.location.href); | ||
|
||
if (isDefined(subdomain) && subdomain.length !== 0) { | ||
if (subdomain.length !== 0) { | ||
url.hostname = `${subdomain}.${domainConfiguration.frontDomain}`; | ||
} | ||
Comment on lines
+15
to
17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: Consider handling invalid/malformed subdomains to prevent invalid URLs |
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Making subdomain required could break existing code that passes undefined. Consider keeping it optional or documenting the breaking change.